Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add constants/float32/two-pi #2126

Merged
merged 1 commit into from
Apr 5, 2024
Merged

feat: add constants/float32/two-pi #2126

merged 1 commit into from
Apr 5, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Apr 5, 2024 •
edited
Loading

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

  • Code coverage report:
Screenshot 2024-04-05 at 22 50 21

  • I have followed the function descriptions used in constants/float64/two-pi.

  • Values for reference:

     In [7]: var float64ToFloat32 = require("@stdlib/number/float64/base/to-float32");

 In [8]: console.log(float64ToFloat32(6.283185307179586))
 6.2831854820251465

    repl was really useful here.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@gunjjoshi gunjjoshi mentioned this pull request Apr 5, 2024
Closed
3 tasks
@kgryte
Copy link
Member

kgryte commented Apr 5, 2024

For future reference, you can find out if an alias is available for a particular package by running

In [1]: pkg2alias( '@stdlib/number/float64/base/to-float32' )
'base.float64ToFloat32'

This way you don't have to explicitly require packages which are already available.

@gunjjoshi
Copy link
Member Author

For future reference, you can find out if an alias is available for a particular package by running

In [1]: pkg2alias( '@stdlib/number/float64/base/to-float32' )
'base.float64ToFloat32'

This way you don't have to explicitly require packages which are already available.

Okay, I tried this just now, the alias is already available. Thanks for sharing!

kgryte
kgryte approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kgryte kgryte merged commit 607aad5 into stdlib-js:develop Apr 5, 2024
7 checks passed
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Apr 5, 2024
@gunjjoshi gunjjoshi deleted the float32-two-pi branch April 5, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gunjjoshi @kgryte